[8.18] [Performance] Refactor TTFMP query from, to fields (#213911)#217091
Merged
awahab07 merged 7 commits intoelastic:8.18from Apr 7, 2025
Merged
[8.18] [Performance] Refactor TTFMP query from, to fields (#213911)#217091awahab07 merged 7 commits intoelastic:8.18from
from, to fields (#213911)#217091awahab07 merged 7 commits intoelastic:8.18from
Conversation
Currently Kibana forwards `query_range_secs` and `query_offset_secs` to mark the selected time range when reporting TTFMP event. This format caused some challenges to identify `from`, `to` date offsets in visualizations. To simplify, the PR renames and sends the three fields explicitly: - `query_from_offset_secs` offset to `0` (now), with -ve for past and +ve for future dates - `query_to_offset_secs` offset to `0` (now), with -ve for past and +ve for future dates - `query_range_secs` same as previously sent _This approach is followed after a discussion, and based on the [gist](https://gist.github.com/andrewvc/1f04a57a336d768e4ec5ff2eff06ba54) excerpt:_ ``` Earliest date -> QueryFrom Newest date -> QueryTo Duration -> QueryRange ``` ### Indexing These fields then should be mapped in the EBT indexer to ingest in the top level of the document, eventually removing the need to create runtime fields in data views for visualizations. Also, runtime fields in data views should be updated to reflect this change. For backward compatibility, the runtime fields can cater both the old and new field names conditionally. ### Testing - Ensure that the TTFMP events are correctly reporting the date ranges. ### Example  (cherry picked from commit e6e78ac) # Conflicts: # src/core/packages/analytics/browser-internal/src/track_performance_measure_entries.test.ts # src/core/packages/analytics/browser-internal/src/track_performance_measure_entries.ts # src/platform/packages/shared/kbn-ebt-tools/src/performance_metrics/context/measure_interaction/index.ts # src/platform/packages/shared/kbn-ebt-tools/src/performance_metrics/context/measure_interaction/measure_interaction.test.tsx
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.18:from,tofields (#213911)Questions ?
Please refer to the Backport tool documentation